chore(core): end "Array Tree Editing" beta #7411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
pedrobonamin
requested review from
RitaDias,
a team and
binoy14
and removed request for
cngonzalez and
a team
|
No changes to documentation |
RitaDias
reviewed
Aug 22, 2024
RitaDias
reviewed
Aug 22, 2024
RitaDias
requested changes
Aug 22, 2024
|
Component Testing Report Updated Aug 22, 2024 12:17 PM (UTC) ✅ All Tests Passed -- expand for details
|
pedrobonamin
commented
Aug 22, 2024
| @@ -42,17 +42,17 @@ test(`file drop event should not propagate to dialog parent`, async ({ | |||
|
|
|||
| // Open the dialog. | |||
| await page.getByRole('button', {name: fileName}).click() | |||
| await expect(page.locator('#tree-editing-dialog')).toBeVisible() | |||
| await expect(page.getByRole('dialog')).toBeVisible() | |||
There was a problem hiding this comment.
This test file has been updated to how it was before the array tree editing feature
jordanl17
pushed a commit
that referenced
this pull request
Aug 29, 2024
* chore(core): end "Array Tree Editing" beta * chore(tests): skip tree editing tests * chore(types): deprecate treeEditing option in arrays * fix(tests): revert array tests to before tree editing dialog
This was referenced Sep 20, 2024
This was referenced Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This changes disable the "Array Tree Editing" beta feature for everyone, even those that opted in to the beta.
Deprecates the beta flag
treeArrayEditingWhat to review
Testing
Notes for release
In version 3.50.0 a month ago we launched a beta of an experimental modal for editing nested objects in arrays. Thank you to everyone who opted in to the beta and gave us valuable feedback on the user experience. We are now ending the experiment and we continue working on alternative ways to navigate nested structured content.